szehon-ho commented on code in PR #17693:
URL: https://github.com/apache/iceberg/pull/17693#discussion_r3920344583
##########
api/src/main/java/org/apache/iceberg/transforms/Transforms.java:
##########
@@ -38,6 +38,17 @@ private Transforms() {}
private static final Pattern HAS_WIDTH =
Pattern.compile("(\\w+)\\[(\\d+)\\]");
+ /**
+ * Parses a transform from its string representation.
+ *
+ * <p>Recognized transforms are {@code identity}, {@code year}, {@code
month}, {@code day}, {@code
+ * hour}, {@code void}, and the width-parameterized {@code truncate[N]} and
{@code bucket[N]} (for
+ * example, {@code truncate[16]} or {@code bucket[8]}). Any other value is
parsed as an unknown
Review Comment:
technically, it can also throw an exception if the parameters are invalid,
so probably say 'unrecognized names produce an UnknownTransform' (add javadoc
link)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
