Fokko commented on PR #3418: URL: https://github.com/apache/iceberg-python/pull/3418#issuecomment-5522774352
@rahulsmahadev I thought of one more thing after submitting the review. Generally, we try to align the properties with the reference Java implementation when possible. I think it would be good to do this here as well. In Java, this is set in HTTPClient: https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/rest/HTTPClient.java This would look like: ```yaml catalog: default: uri: http://rest-catalog/ws/ rest: client: connection-timeout-ms: 5000 # connect timeout (ms) socket-timeout-ms: 60000 # read/socket timeout (ms) max-retries: 5 # retry attempts ``` In Java, the backoff factor cannot be set; I think we can also hard-code it in PyIceberg to 1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
