hedger9487 commented on PR #3631: URL: https://github.com/apache/iceberg-python/pull/3631#issuecomment-5523867141
Hi @moomindani, Thank you for the helpful context regarding #3840! Following our discussion, I have opened a PR against your branch with the `rewrite_if` implementation and unit tests: 👉 https://github.com/moomindani/iceberg-python/pull/1 ### Summary of changes: 1. Added `rewrite_if(predicate: Callable[[ManifestFile], bool]) -> RewriteManifests` to `RewriteManifests`. 2. When a predicate is provided, matching manifests are rewritten even for single-manifest groups (`len(group) == 1`), allowing schema upgrades for #3840. Manifests not matching the predicate are kept as-is. 3. Updated `rewrites_needed()` to evaluate the predicate when provided. 4. Added unit tests covering selective filtering, single-manifest predicate rewrites, and `rewrites_needed`. Please take a look when you have a moment and let me know if there is anything you would like adjusted! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
