rambleraptor commented on code in PR #3864:
URL: https://github.com/apache/iceberg-python/pull/3864#discussion_r3928016627


##########
pyiceberg/catalog/hive.py:
##########
@@ -316,6 +320,7 @@ def _create_hive_client(properties: dict[str, str]) -> 
_HiveClient:
                     properties.get("ugi"),
                     property_as_bool(properties, HIVE_KERBEROS_AUTH, 
HIVE_KERBEROS_AUTH_DEFAULT),
                     properties.get(HIVE_KERBEROS_SERVICE_NAME, 
HIVE_KERBEROS_SERVICE_NAME_DEFAULT),
+                    properties.get(HIVE_KERBEROS_SERVICE_HOST),

Review Comment:
   properties.get should return None if the property isn't set. If that's the 
case, then this is fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to