rdblue commented on code in PR #17932:
URL: https://github.com/apache/iceberg/pull/17932#discussion_r3929002942
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileAdapters.java:
##########
@@ -66,29 +69,54 @@ class TestTrackedFileAdapters {
private static final Schema TABLE_SCHEMA =
new Schema(
- optional(1, "id", Types.IntegerType.get()),
- optional(2, "score", Types.FloatType.get()),
- optional(3, "geom", Types.GeometryType.crs84()));
+ optional(1, "id", Types.IntegerType.get()), optional(2, "score",
Types.FloatType.get()));
private static final Types.StructType CONTENT_STATS_TYPE =
- StatsUtil.statsReadSchema(TABLE_SCHEMA, ImmutableList.of(1, 2, 3));
+ StatsUtil.statsReadSchema(TABLE_SCHEMA, ImmutableList.of(1, 2));
private static final FieldStats<?> ID_STATS =
StatsTestUtil.mockFieldStats(
CONTENT_STATS_TYPE.fieldType("id").asStructType(), 1, 1, 1000, 100L,
5L, null);
private static final FieldStats<?> SCORE_STATS =
StatsTestUtil.mockFieldStats(
CONTENT_STATS_TYPE.fieldType("score").asStructType(), 2, 1.0f,
100.0f, 100L, 10L, 3L);
- private static final FieldStats<?> GEOM_STATS =
- StatsTestUtil.mockFieldStats(
- CONTENT_STATS_TYPE.fieldType("geom").asStructType(), 3, null, null,
100L, 20L, null, 12);
private static final ContentStatsStruct CONTENT_STATS =
new ContentStatsStruct(CONTENT_STATS_TYPE);
static {
CONTENT_STATS.setStats(1, ID_STATS);
CONTENT_STATS.setStats(2, SCORE_STATS);
- CONTENT_STATS.setStats(3, GEOM_STATS);
}
+ private static final Tracking MANIFEST_TRACKING =
+ new TrackingStruct(
+ EntryStatus.ADDED,
+ SNAPSHOT_ID,
+ // data and file sequence numbers must be equal
+ DATA_SEQUENCE_NUMBER,
+ DATA_SEQUENCE_NUMBER,
+ /* dvSnapshotId= */ null,
+ FIRST_ROW_ID,
+ /* deletedPositions= */ null,
+ /* replacedPositions= */ null);
Review Comment:
Most places use `// replaced positions` rather than using an inline comment
before `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
