vbhanuchander-lang commented on issue #15443:
URL: https://github.com/apache/iceberg/issues/15443#issuecomment-5533576473
@trevorpburke the original ask here is done, and the rest is partly in
flight — here is where
`RecordConverter` actually stands on `main` today.
**Variant landed.** `case VARIANT` is handled, added by @seokyun-ha-toss in
#15283 (22 Apr), so the
failure @b4sus originally hit is fixed. If variant is all you needed, it
should work on a current
build.
**What `RecordConverter` covers now:** struct, list, map, integer, long,
float, double, decimal,
boolean, string, uuid, binary, fixed, date, time, timestamp and variant.
Anything else falls through
to `throw new UnsupportedOperationException("Unsupported type: " +
type.typeId())`.
**So the remaining v3 gaps are:** `timestamp_ns`, `geometry`, `geography`
and `unknown`.
Of those, **`timestamp_ns` has an open PR — #17613** — which adds the
missing `case` plus tests. The
generic object model already handles the type (`GenericDataUtil` has the
`TIMESTAMP_NANO` branch), so
it is a small change rather than new machinery. It has been green and
waiting for a review since
12 August. `geometry`, `geography` and `unknown` are untouched as far as I
can see.
Worth noting this issue is filed as one bug for "variant and possibly other
v3 types", which makes it
hard to close: the variant part is finished while three types remain. It
might be easier to track if
it were narrowed to the remaining types, or split — but that is for a
maintainer to decide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
