jarosmpost commented on code in PR #17789:
URL: https://github.com/apache/iceberg/pull/17789#discussion_r3934623037
##########
aws/src/main/java/org/apache/iceberg/aws/lakeformation/LakeFormationAwsClientFactory.java:
##########
@@ -84,7 +99,8 @@ public S3Client s3() {
.applyMutation(s3FileIOProperties()::applyServiceConfigurations)
.applyMutation(s3FileIOProperties()::applyRetryConfigurations)
.credentialsProvider(
- new LakeFormationCredentialsProvider(lakeFormation(),
buildTableArn()))
+ new LakeFormationCredentialsProvider(
+ lakeFormation(), buildTableArn(), cacheEnabled,
cacheRefreshLeadTimeMs))
Review Comment:
Reworked this to support multiple factories/partitions. The standard factory
now uses a JVM-wide
provider registry keyed by the table ARN and immutable catalog properties,
so independently created
`LakeFormationAwsClientFactory` instances share credentials only for the
same table and
authentication context. Entries are removed after a configurable idle period
(`lakeformation.credential-cache.expiration-seconds`, default 60s). A custom
factory can override
`lakeFormationCredentialsProvider()` and use
`directLakeFormationCredentialsProvider()` to bypass
sharing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
