alessandro-nori opened a new pull request, #3148:
URL: https://github.com/apache/iceberg-rust/pull/3148

   Closes #3147.
   
   The Parquet writer ignored `write.parquet.bloom-filter-enabled.column.*`, 
`-fpp.column.*` and `-ndv.column.*`, so tables configured for bloom filters 
silently got files without them.
   
   **Changes**
   - `TableProperties`: three prefixed-map properties for the per-column bloom 
settings.
   - `ParquetWriterBuilder::from_table_properties`: apply them to the 
parquet-rs writer properties, mirroring Iceberg Java — the `-enabled.column.` 
entries decide which columns are configured, and `fpp`/`ndv` are only consulted 
for a column present there.
   - Columns the schema does not contain, non-leaf columns, and list/map 
descendants are skipped rather than failing the write (Iceberg names an element 
`a.element`, Parquet writes it at `a.list.element`; translating needs the 
Parquet schema, which is not built until write time).
   - Tests covering each of those paths.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to