vbhanuchander-lang commented on PR #17552: URL: https://github.com/apache/iceberg/pull/17552#issuecomment-5547433229
@danielcweeks @twthorn Different fix, as far as I can tell — this one guards `commitConsumerOffsets()` against a stale coordinator committing over another's position, #17933 stops `controlTopicOffsets` itself from moving backwards in `consumeAvailable()` on a re-read. I ran each PR's tests against the other's fix and both sets fail, so neither subsumes the other; details and the test output are in https://github.com/apache/iceberg/pull/17933#issuecomment-5547431272. They touch different methods and do not conflict textually, so nothing here needs to wait on that one — I will rebase #17933 on top of this once it lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
