mattfaltyn commented on PR #1988: URL: https://github.com/apache/iceberg-go/pull/1988#issuecomment-5557842249
> Adding one case with a sub-1000 partition field ID and a lower counter (expect the greatest field ID, not 999) would pin it. Thanks for the precise mutation-based recommendation. I added TestAssignMissingPartitionFieldIDsNormalizesLegacyStaleCounter and confirmed it fails with actual 999 when the write site uses the allocation cursor. > Issue #1987 asks for coverage that asserts both that the parsed counter becomes 1000 and that the next distinct partition field receives 1001. Great call. I extended TestParseMetadataBytesNormalizesStaleLastPartitionID with a bucket[16](x) assertion for field ID 1001. Both updates are in e01dbb2. The full test suite and golangci-lint pass. Thank you for the thorough review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
