smaheshwar-pltr commented on issue #17990: URL: https://github.com/apache/iceberg/issues/17990#issuecomment-5564815958
I think the fix we should proceed with initially involved preventing this key loss, not making everything e.g. the encryption manager thread safe (`TableOperations` themselves often have lack any synchronization - https://github.com/apache/iceberg/pull/13225/files#r3175544692, but those data races are "benign" and don't lead to corruption). That fix is centred around point (5) in the steps above, and is similar to https://github.com/apache/iceberg/pull/16525. It involved committing keys along with snapshots in table metadata to avoid the two drifting - #17984. There may still be races on the `StandardEncryptionManager` that fail loudly (that's why I've avoided adding a full concurrency test in that PR that might flake), but unreadable snapshots will no longer be committed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
