stevenzwu commented on pull request #1956: URL: https://github.com/apache/iceberg/pull/1956#issuecomment-759633809
I looked at the Beam's approach (gradle magic to copy version specific code + shim/compat layer) that @tweise suggested. It seems to be the most flexible and can work here. It does add some complexity though, mainly on the gradle setup initially. Anyone is more familiar with gradle likes to take it up? FLIP-27 source implementation can live in the 1.12 sub module (with gradle trick to copying code during build). HiveShim approach in Flink probably won't work with the FLIP-27 source implementation, which requires Flink 1.12 dep. @tweise any drawbacks of the Beam approach on supporting different Flink versions that we should be aware? like how does it work with IDE? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
