dannycjones commented on code in PR #2933: URL: https://github.com/apache/iceberg-rust/pull/2933#discussion_r3956494756
########## crates/iceberg/src/spec/datatypes.rs: ########## @@ -43,6 +43,8 @@ pub const MAP_VALUE_FIELD_NAME: &str = "value"; pub(crate) const MAX_DECIMAL_BYTES: u32 = 24; pub(crate) const MAX_DECIMAL_PRECISION: u32 = 38; +const DEFAULT_GEOSPATIAL_CRS: &str = "OGC:CRS84"; +const EQUIVALENT_DEFAULT_GEOSPATIAL_CRS: &str = "EPSG:4326"; Review Comment: I did some digging on this (with some LLM help). SedonaDB reverted normalization, keeping equivalence: https://github.com/apache/sedona-db/pull/962/changes#diff-921113fc524a2d3b621c6fa52e9880515cb5929a8499e85fb5fa4f80bf8a8e88R932-R941 iceberg-java didn't merge normalization, even maintaining the original case but allowing comparison to consider two strings with different casing equal. note that there's no equality I found between CRSes in the Iceberg layer. https://github.com/apache/iceberg/pull/16765#discussion_r3476481966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
