plusplusjiajia opened a new pull request, #927:
URL: https://github.com/apache/iceberg-cpp/pull/927
`rest_catalog.h` is installed and includes
`iceberg/catalog/session_catalog.h`, which is not — so a downstream project
consuming the installed package and using the REST catalog fails to compile:
fatal error: iceberg/catalog/session_catalog.h: No such file or directory
The three headers under `src/iceberg/catalog` (`session_catalog.h`,
`session_context.h`, `catalog_util.h`) are already installed by the Meson
build, and every sibling directory in CMake (`data`, `expression`, `manifest`,
…) calls `iceberg_install_all_headers`. Only
`src/iceberg/catalog/CMakeLists.txt` was missing the call
— another instance of #894.
Verified by installing from `main` and building a downstream
`find_package(iceberg CONFIG REQUIRED COMPONENTS bundle rest)` project that
includes `rest_catalog.h`: it fails before this change and builds after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
