nssalian commented on PR #17534: URL: https://github.com/apache/iceberg/pull/17534#issuecomment-5586558666
> On another note, these are already big changes touching a lot of files, so I'm not sure whether mixing them with feature work would really help... I think that would probably make it even more messy. I should clarify: I meant modifying just the surface of the code that new features/ fixes add. Not addressing all at once. Again, this was left to reviewer/maintainer discretion while reviewing the code changes. The whole idea was not to do this in one go. I don't think there was objection to doing the changes themselves. > Also, I would be happy to close these PRs if the maintainers suggest so, but in that case - why don't we also disable the StatementSwitchToExpressionSwitch warnings? This might be a good intermediate solution. I do think we should do a pass and figure out how to add newer JDK features - records, switch statements as a community overall, but that's a larger discussion. @uros-b there are past threads on this; feel free to restart them or start a new topic so we can discuss it on the mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
