smaheshwar-pltr commented on code in PR #18014:
URL: https://github.com/apache/iceberg/pull/18014#discussion_r3958006346
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -625,8 +624,8 @@ protected EncryptedOutputFile newManifestOutputFile() {
String manifestFileLocation =
ops.metadataFileLocation(
manifestFormat.addExtension(commitUUID + "-m" +
manifestCount.getAndIncrement()));
- return EncryptingFileIO.combine(ops.io(), ops.encryption())
- .newEncryptingOutputFile(manifestFileLocation);
+ OutputFile rawOutputFile = ops.io().newOutputFile(manifestFileLocation);
+ return ops.encryption().encrypt(rawOutputFile);
Review Comment:
As mentioned in
https://github.com/apache/iceberg/pull/17987#discussion_r3957907385 this is
mostly just for consistency, so I want to wait to see what we decide in
https://github.com/apache/iceberg/pull/17987. If we decide against this change,
I'll close this one out
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -625,8 +624,8 @@ protected EncryptedOutputFile newManifestOutputFile() {
String manifestFileLocation =
ops.metadataFileLocation(
manifestFormat.addExtension(commitUUID + "-m" +
manifestCount.getAndIncrement()));
- return EncryptingFileIO.combine(ops.io(), ops.encryption())
- .newEncryptingOutputFile(manifestFileLocation);
+ OutputFile rawOutputFile = ops.io().newOutputFile(manifestFileLocation);
+ return ops.encryption().encrypt(rawOutputFile);
Review Comment:
As mentioned in
https://github.com/apache/iceberg/pull/17987#discussion_r3957907385 this is
mostly just for consistency, so I want to wait to see what we decide in
https://github.com/apache/iceberg/pull/17987. If we decide against this change,
I'll close this PR out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
