zakariya-s commented on code in PR #3173: URL: https://github.com/apache/iceberg-rust/pull/3173#discussion_r3957755848
########## crates/kms/aws/src/client.rs: ########## Review Comment: Yeah I'm not sure either, I considered both but for opendal the backends all share the same adapter while the KMS implementations wouldn't have the same. Java Iceberg also has separate modules for AWS, etc. Having them in separate crates also keeps SDK deps isolated. I can see three potential ways to organise this: - Keep it in the core crate and use feature flags - Have separate crates for iceberg-kms-aws, etc. - Have one iceberg-kms crate with feature flags for AWS, etc. I'm happy with any of these approaches honestly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
