vbhanuchander-lang opened a new pull request, #18022:
URL: https://github.com/apache/iceberg/pull/18022

   Closes #17076
   
   ## Summary
   
   `RecordConverter.convertUUID()` returned `byte[]` when 
`write.format.default=parquet`. After #11904, `ParquetValueWriters.uuids()` is 
a `PrimitiveWriter<UUID>` and does the byte conversion itself, so writes threw 
`ClassCastException: class [B cannot be cast to class java.util.UUID`.
   
   The Parquet-only `byte[]` branch is removed so `convertUUID()` always 
returns `java.util.UUID`, matching ORC and Avro.
   
   This is the same fix as #17079 (stale-bot closed, never reviewed). Credit to 
@thswlsqls for the original diagnosis and patch. The extra change here is a 
write-through test: the old `testUUIDConversionWithParquet` only asserted the 
converter's return type, so it passed on a converter that still could not write.
   
   ## Testing done
   
   - `testUUIDConversionWithParquet` now expects the original `UUID`
   - `testUUIDParquetWriteRoundTrip` appends through `Parquet.write(...)` and 
reads the value back
   - `./gradlew :iceberg-kafka-connect:iceberg-kafka-connect:test --tests 
org.apache.iceberg.connect.data.TestRecordConverter` — BUILD SUCCESSFUL
   
   
   Made with [Cursor](https://cursor.com)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to