rambleraptor commented on code in PR #3924:
URL: https://github.com/apache/iceberg-python/pull/3924#discussion_r3971162688
##########
tests/catalog/test_hive.py:
##########
@@ -293,6 +297,7 @@ def test_create_table(
catalog._client = MagicMock()
catalog._client.__enter__().create_table.return_value = None
catalog._client.__enter__().get_table.return_value = hive_table
+ catalog._client.__enter__().get_table_req.return_value =
GetTableResult(table=hive_table)
Review Comment:
I mostly agree. If it's alright with you, let's get this merged (to unblock
the rest of our wonderful contributors) and then I'll send out a quick
follow-up to remove the mocks. We can have a discussion there.
(I really dislike mocked tests, so I need very little excuse to get rid of
them)
##########
dev/docker-compose-integration.yml:
##########
@@ -98,8 +98,6 @@ services:
image: pyiceberg-hive:latest
build:
context: hive/
- args:
- MAVEN_MIRROR: ${MAVEN_MIRROR:-https://repo1.maven.org/maven2}
Review Comment:
That's a fantastic point. Adding that back in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
