viirya commented on PR #2635: URL: https://github.com/apache/iceberg-rust/pull/2635#issuecomment-5607847376
Thanks for the approval and the detailed feedback! Updated in cc794c82, which also merges the latest upstream main and resolves the conflicts. I tightened the `Null` arm to `Some(_)` and added assertions for the nested field IDs, including the element of `s.ys`. I also added a TODO at the default extraction to document the existing complex-default gap. The implementation and regression coverage for complex defaults can stay together in a follow-up, consistent with the earlier discussion about widening the helpers to accept `Literal`. All 1,675 iceberg library tests pass locally, along with clippy and formatting checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
