thswlsqls commented on PR #17045: URL: https://github.com/apache/iceberg/pull/17045#issuecomment-5610435944
@LuciferYang Thanks for the verification and the Kyuubi context — both observations hold, and I'll drop the `this == AlwaysNull.INSTANCE` term in this PR. Once `AlwaysNull` overrides `bind`, that term can't be reached, and it's what lets the call fall through to the `checkArgument` that dereferences the null `field`. `DynMethods.UnboundMethod` has no equivalent term and overrides `bind` on `NOOP`, so removing it lines the two up. The `set(Object, Void)` bridge is a separate problem — agreed it's out of scope here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
