Copilot commented on code in PR #3188:
URL: https://github.com/apache/iceberg-rust/pull/3188#discussion_r3976443542
##########
.github/workflows/publish.yml:
##########
@@ -50,6 +50,11 @@ jobs:
with:
rust-version: ${{ steps.get-msrv.outputs.msrv }}
+ # Publishing uses crates.io trusted publishing only. The token is minted
per
+ # run via OIDC; there is no long-lived CARGO_REGISTRY_TOKEN secret and
one
+ # should not be added as a fallback. Trusted publishing cannot create a
+ # crate, so new crates are reserved before their PR merges instead; see
+ # "Adding a new crate" in website/src/release.md.
Review Comment:
This cross-reference does not match the release guide: there is no “Adding a
new crate” section, so readers cannot find the instructions. Please point to
the existing “Publishing a crate for the first time” heading (or update the
guide and heading consistently).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
