blackmwk commented on code in PR #3184:
URL: https://github.com/apache/iceberg-rust/pull/3184#discussion_r3978047095
##########
.github/workflows/ci.yml:
##########
@@ -152,6 +152,11 @@ jobs:
cargo check -p "$pkg" --all-targets || exit 1
done
+ # Dry-runs the publish.yml command to catch crates that cannot be
published,
+ # such as packages missing files or dependency cycles between workspace
crates.
+ - name: Check each crate can be published
+ run: cargo publish --workspace --all-features --dry-run
Review Comment:
> @blackmwk Is your concern that it'll use up too much CI time?
Yes. How about this, we do this check with `--no-verify` on each pr, and do
this check without `--no-verify` on publish workflow for rc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
