kevinjqliu commented on code in PR #3195:
URL: https://github.com/apache/iceberg-rust/pull/3195#discussion_r3981695280
##########
.github/workflows/asf-allowlist-check.yml:
##########
@@ -25,6 +25,7 @@ name: "ASF Allowlist Check"
on:
pull_request:
+ merge_group:
Review Comment:
allows this workflow to run in merge queue
##########
.github/workflows/bindings_python_ci.yml:
##########
@@ -22,19 +22,7 @@ on:
branches:
- main
pull_request:
- paths:
Review Comment:
we need to get rid of all `paths:` filters, otherwise merge queue might be
blocked.
i think this is a good tradeoff in order to enable merge queue. and we can
look at optimizations at a later time
##########
.github/workflows/bindings_python_ci.yml:
##########
@@ -121,3 +109,17 @@ jobs:
HF_DATASET: ${{ secrets.HF_DATASET }}
run: |
make test
+
+ bindings-python-ci-required:
Review Comment:
add this so we dont need to add all the checks to the `contexts:` block in
`.asf.yaml` and instead just reference this one check by name.
otherwise we'd have to keep them in sync
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
