rymurr commented on pull request #1825: URL: https://github.com/apache/iceberg/pull/1825#issuecomment-760091723
Thanks for the review @jackye1995 I have updated based on your comments. The last question is what to do about timezones. @rdblue I agree that handling timestamps on our own is icky however we will likely end up having to anyways. We would like to be able to support queries that compare tables across versions/times (eg a join between `table1@time1` and `table1@time2`) and be able to do this consistently on different engines. I suppose in time we can delegate to the Spark timestamp parsing logic if it can be found via reflection but in the end we will still have to parse timestamps at this level. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
