yangshangqing95 commented on code in PR #18055:
URL: https://github.com/apache/iceberg/pull/18055#discussion_r3983510206
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##########
@@ -105,6 +105,27 @@ public void testRowGroupSizeConfigurable() throws
IOException {
}
}
+ @Test
+ public void testRowGroupSizeLargerThanIntegerMax() throws IOException {
+ Schema schema = new Schema(optional(1, "intCol", IntegerType.get()));
+ org.apache.avro.Schema avroSchema =
AvroSchemaUtil.convert(schema.asStruct());
+ GenericData.Record record = new GenericData.Record(avroSchema);
+ record.put("intCol", 1);
+
+ // Values above Integer.MAX_VALUE used to fail in
PropertyUtil.propertyAsInt.
+ File file = createTempFile(temp);
+ write(
+ file,
+ schema,
+ ImmutableMap.of(PARQUET_ROW_GROUP_SIZE_BYTES, Long.toString(4L * 1024
* 1024 * 1024)),
Review Comment:
Nit, non-blocking:
can we also add a test about
`DELETE_PARQUET_ROW_GROUP_SIZE_BYTES` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
