linhongyu510 commented on PR #3145: URL: https://github.com/apache/iceberg-rust/pull/3145#issuecomment-5626167175
Addressed the latest review in `a27d15970`: - restored `DataInvalid` at index construction when a Puffin position delete lacks `referenced_data_file`; the regression test now exercises the manifest-to-index path - replaced the infallible `From<&DeleteFileContext>` conversion with `TryFrom` and propagated builder errors through all delete-file lookup paths - kept loader-side required-field checks for deserialized/hand-written scan plans, so malformed tasks return `DataInvalid` instead of panicking - applied non-negative validation to any provided `content_offset` / `content_size_in_bytes`, including non-DV delete files - kept the coordinate fields optional because ordinary Parquet delete files legitimately omit them; kept the signed manifest representation and checked conversion to `u64` at the read boundary - updated the PR description to call out private fields as a 0.11 downstream breaking change I left the independent `pos_deletes_by_referenced_data_file` rename out of this bug fix to avoid expanding scope. Verification: 63 focused tests passed; workspace fmt, all-target/all-feature Clippy with `-D warnings`, and `git diff --check` passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
