anoopj commented on code in PR #3177:
URL: https://github.com/apache/iceberg-rust/pull/3177#discussion_r3984459981
##########
crates/iceberg/src/arrow/reader/predicate_visitor.rs:
##########
@@ -590,7 +596,7 @@ impl BoundPredicateVisitor for PredicateConverter<'_> {
// update this if arrow ever adds a native is_in kernel
let left = project_column(&batch, idx)?;
- let mut acc = BooleanArray::from(vec![false;
batch.num_rows()]);
+ let mut acc =
BooleanArray::new(BooleanBuffer::new_unset(batch.num_rows()), None);
Review Comment:
Added `test_constant_bool_array` to do the assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
