moomindani commented on PR #16574: URL: https://github.com/apache/iceberg/pull/16574#issuecomment-5627898894
@huaxingao would you be able to review this one? You merged #16310 in May, so you have recent context in this area, and this PR has not had a committer look at it since it was opened. It adds four catalog properties — include and exclude, on table name and on namespace — that let a deployment restrict which tables a `MetricsReporter` emits for, applied uniformly through a `FilteringMetricsReporter` wrapper rather than reporter by reporter. The motivation is cardinality: on a catalog with many tables, emitting for all of them is often not affordable, and today the choice is all or nothing. @gaborkaszab reviewed a May revision and his points are addressed, including a gap his review turned up in the REST reporter. Rebased onto current `main`, 44/44 green. It shares no commits with #16250 and can be reviewed on its own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
