kaiwangleo commented on issue #16646: URL: https://github.com/apache/iceberg/issues/16646#issuecomment-5628425799
Thanks for the discussion and for raising the concerns about exposing `DROP PARTITION` through the default Flink catalog. I reviewed the related dev@iceberg discussion. The main concerns are that Iceberg uses hidden partitioning, `DROP PARTITION` has no corresponding `ADD PARTITION` operation, and the feature may be more appropriate for Hive-to-Iceberg migration tooling or a connector-specific extension. The discussion also noted that partition evolution requires additional consideration. The current implementation is intentionally limited to identity partition fields. It translates the Flink partition specification into an Iceberg row filter, relies on `deleteFromRowFilter` for strict projection validation, and avoids creating a snapshot when `DROP IF EXISTS` targets a missing partition. Tests cover typed values, null values, missing tables or partitions, unsupported transforms, and all supported Flink versions. However, given the lack of clear community consensus and the concern about adding this behavior to the default `FlinkCatalog`, I think the API placement and semantics should be confirmed before merging. In particular, we should decide whether this belongs in the default catalog, a migration-specific tool, or a connector-specific extension, and document the expected behavior across partition evolution. Would maintainers prefer to continue with the default Flink catalog implementation, or should this work be redirected to a use-case-specific extension? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
