moomindani commented on PR #3623: URL: https://github.com/apache/iceberg-python/pull/3623#issuecomment-5630612793
Not stale — this is a draft that is blocked on #3551, and there has been real movement there. @rambleraptor updated #3551 on 8 September: `next_row_id` now has a default for new tables, and there is a Spark read test against a v3 table written by PyIceberg. `encryption-key` is deliberately deferred to a separate PR. He has asked @Fokko, @kevinjqliu and @geruh for review. Nothing to do here until that lands. Restating why the one red check is expected rather than a defect, since it has come up before: upgrading to v3 produces a `TableMetadataV3`, and persisting it still raises `NotImplementedError: Writing V3 is not yet supported` (#1551) because v3 serialization is exactly what #3551 adds. `tests/integration/test_reads.py::test_upgrade_table_version[session_catalog_hive]` is the single failure; the other 486 tests pass. Once #3551 is in, this PR is a rebase plus removing that expectation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
