uros-b commented on code in PR #18056:
URL: https://github.com/apache/iceberg/pull/18056#discussion_r3988023161
##########
build.gradle:
##########
@@ -1261,9 +1261,13 @@ project(':iceberg-bom') {
def sparkScalaVersions = [
"3.5": ["2.12", "2.13"],
]
+ // Projects that build a distribution rather than a Maven artifact
disable their publishing
+ // tasks, so their POM is never published and the BOM must not reference
it.
+ def unpublishedProjects = ['iceberg-kafka-connect-runtime']
Review Comment:
`unpublishedProjects` is a hardcoded one-entry list, a future
distribution-only module that disables publishing in afterEvaluate must be
added to this list manually or the BOM silently re-references an unpublished
POM, reproducing the exact bug this PR fixes.
You already surfaced a self-maintaining alternative: a shared
ext.skipPublish = true flag set in the project's own build file and readable in
the configuration phase, which would handle future cases automatically. The
explicit list is technically sound given the afterEvaluate-vs-configuration
ordering constraint (reading task state in the configuration phase would be
order-dependent), but Iceberg's connector surface is expanding, so perhaps we
should consider the other approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
