mithun-sudo opened a new pull request, #18066: URL: https://github.com/apache/iceberg/pull/18066
## Summary - DynamicIcebergSink with `caseSensitive(false)` can write NULL for columns whose names differ only by case. - `CompareSchemasVisitor` matches names case-insensitively and returns `DATA_CONVERSION_NEEDED`, but `DataConverter` used `RowType.getFieldIndex` (exact match), so the source field looked missing. - Thread `caseSensitive` into `DataConverter` and look up fields with `equalsIgnoreCase` when matching is case-insensitive. ## Test plan - [x] `TestRowDataConverter` case-insensitive remap (values kept, missing optional field is null) - [x] `TestDynamicIcebergSink.testCaseInsensitiveDataConversionDropsValues` - [x] `./gradlew :iceberg-flink:iceberg-flink-2.3:test -DflinkVersions=2.3 --tests org.apache.iceberg.flink.sink.dynamic.TestRowDataConverter --tests org.apache.iceberg.flink.sink.dynamic.TestDynamicIcebergSink.testCaseInsensitiveDataConversionDropsValues` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
