nastra commented on code in PR #17579:
URL: https://github.com/apache/iceberg/pull/17579#discussion_r3988257893
##########
flink/v2.3/flink/src/test/java/org/apache/iceberg/flink/DataGenerators.java:
##########
@@ -64,12 +61,11 @@
public class DataGenerators {
public static class Primitives implements DataGenerator {
- private static final DateTime JODA_DATETIME_EPOC =
- new DateTime(1970, 1, 1, 0, 0, 0, 0, DateTimeZone.UTC);
- private static final DateTime JODA_DATETIME_20220110 =
- new DateTime(2022, 1, 10, 0, 0, 0, 0, DateTimeZone.UTC);
+ private static final OffsetDateTime DATETIME_20220110 =
Review Comment:
looks like this is duplicating what JAVA_OFFSET_DATE_TIME_20220110 already
defines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
