RussellSpitzer commented on code in PR #17984:
URL: https://github.com/apache/iceberg/pull/17984#discussion_r3992130193
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -354,6 +360,11 @@ public Snapshot apply() {
replacedRecords);
}
+ // Each call creates a new key; use this result for both the snapshot and
key lookup.
Review Comment:
Why not just fix "toManifestListFile() rather than adding a comment? Feels
like we do want this to be idempotent right?
```java
public ManifestListFile toManifestListFile() {
if (manifestListFile == null) {
manifestListFile = ... // current body
}
return manifestListFile;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
