anuragmantri commented on PR #3128: URL: https://github.com/apache/iceberg-rust/pull/3128#issuecomment-5641443137
Thanks for the thorough review, @laskoviymishka. Pushed a commit addressing all of it: `sort_order_id` is now carried alongside `sort_order`, the serde guard is dropped, `ManifestFileContext` carries a narrow sort-orders map instead of full table metadata, and the test/doc/fixture nits are fixed. Replied inline on each thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
