Copilot commented on code in PR #3203: URL: https://github.com/apache/iceberg-rust/pull/3203#discussion_r3994251973
########## .github/workflows/ci.yml: ########## @@ -18,9 +18,6 @@ name: CI on: - push: - branches: - - main pull_request: merge_group: Review Comment: Removing the `push` trigger makes all four `rust-cache` `save-if` conditions in this workflow unreachable (`github.event_name == 'push' && github.ref == 'refs/heads/main'` at lines 126, 147, 188, and 218). After this change, main merges can no longer refresh those caches, so lockfile or toolchain changes will leave CI repeatedly rebuilding from cold caches. Please update the save condition to a trusted event that still runs (or otherwise preserve the intended cache scope). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
