charliec05 commented on code in PR #17962:
URL: https://github.com/apache/iceberg/pull/17962#discussion_r3994627613
##########
dell/src/main/java/org/apache/iceberg/dell/ecs/EcsSeekableInputStream.java:
##########
@@ -69,6 +70,7 @@ public long getPos() {
@Override
public void seek(long inputNewPos) {
+ Preconditions.checkArgument(inputNewPos >= 0, "Position is negative: %s",
inputNewPos);
Review Comment:
Addressed in 7d6809ee0. The negative-position message now exactly matches S3
(`position is negative: %s`). ECS did not previously track closure, so I added
the closed-state guard before validating or changing a seek position. Reads
also check closure before using or opening the underlying stream. Regression
coverage exercises closure before the first read and after the stream has been
opened, then verifies that seek and both read methods reject access without
changing position. The full Dell test suite, Spotless, and main/test Checkstyle
pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
