kevinjqliu commented on code in PR #3954:
URL: https://github.com/apache/iceberg-python/pull/3954#discussion_r3997233085
##########
tests/integration/test_rest_manifest.py:
##########
@@ -112,7 +111,7 @@ def test_write_sample_manifest(table_test_all_types: Table,
compression: AvroCom
wrapped_entry_v2 = copy(entry)
wrapped_entry_v2.data_file = wrapped_data_file_v2_debug
wrapped_entry_v2_dict = todict(wrapped_entry_v2, [field.name for field in
test_spec.fields])
- for field in ("first_row_id", "content_offset", "content_size_in_bytes"):
+ for field in ("first_row_id", "content_offset", "content_size_in_bytes",
"spec_id"):
Review Comment:
`spec_id` is not serialized so we need to remove it for this comparison to
work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
