sungwy commented on code in PR #18079:
URL: https://github.com/apache/iceberg/pull/18079#discussion_r3997276143
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -149,11 +150,15 @@ public S3FileIO(SerializableSupplier<S3Client> s3,
SerializableSupplier<S3AsyncC
@Override
public InputFile newInputFile(String path) {
- return S3InputFile.fromLocation(path, clientForStoragePath(path), metrics);
+ return newInputFile(path, 0);
}
@Override
public InputFile newInputFile(String path, long length) {
+ if (PreSignedUrlInputFile.isHttpUrl(path)) {
+ return PreSignedUrlInputFile.of(path, length);
Review Comment:
as designed under the current assumption that http / https scheme is the
discriminator that a location is presigned url as opposed to the native location
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
