dchahla opened a new pull request, #3215: URL: https://github.com/apache/iceberg-rust/pull/3215
A partition field whose name matches a schema column is accepted only for the identity transform. Void belongs in the same allowance: it always produces null, so it cannot carry a value that disagrees with the column it shares a name with. Rejecting it blocks the usual way a v1 table drops a partition field, which is to rewrite the field's transform from identity to void while leaving its name and source alone, so a spec that was valid before the edit stops binding after it. The rule is enforced in two places, PartitionSpecBuilder and TableMetadataBuilder, and both are updated so they agree. In both paths a void field whose name matches a column it is not sourced from is still rejected, and transforms other than identity and void are still rejected on a name collision. The two error messages named the identity transform and would have been misleading once void is permitted, so they now name both. ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## AI Disclosure <!-- https://iceberg.apache.org/contribute/#guidelines-for-ai-assisted-contributions --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
