tomtongue commented on PR #16859: URL: https://github.com/apache/iceberg/pull/16859#issuecomment-5665969902
@laskoviymishka Thanks so much for the detailed review. I addressed your comments and responded in regards to Exception handling and field ID handling. For the follow-ups, > missing historical metadata files are handled gracefully, but other IO errors still fail the query After reconsidering the error handling, I decided to keep this behavior like missing historical metadata files produce null and a warning, while other read failures propagate to the caller as I commended above. > since this exposes full historical properties, it would be good to track the same surface in iceberg-go/PyIceberg and add a short docs note about sensitive or credential-like properties I thought that once this PR is merged, I start implementing other modules. Thanks for the suggestions. For the secret table properties, I'm going to make and share a doc based on the current implementation. --- @singhpk234 @szehon-ho If you have a chance, could you review the new changes I applied, and share your feedback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
