kevinjqliu commented on code in PR #3958:
URL: https://github.com/apache/iceberg-python/pull/3958#discussion_r4006918631
##########
pyiceberg/schema.py:
##########
@@ -115,16 +115,13 @@ def __len__(self) -> int:
def __eq__(self, other: Any) -> bool:
"""Return the equality of two instances of the Schema class."""
- if not other:
- return False
-
if not isinstance(other, Schema):
return False
if len(self.columns) != len(other.columns):
return False
- identifier_field_ids_is_equal = self.identifier_field_ids ==
other.identifier_field_ids
Review Comment:
yea i think that might be a better long term design. Something like
`frozenset[int]` would be representative
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
