rambleraptor commented on code in PR #3971: URL: https://github.com/apache/iceberg-python/pull/3971#discussion_r4017860901
########## pyiceberg/io/pyarrow.py: ########## @@ -195,8 +195,8 @@ logger = logging.getLogger(__name__) -ONE_MEGABYTE = 1024 * 1024 BUFFER_SIZE = "buffer-size" +_DEFAULT_BUFFER_SIZE = 8 * 1024 * 1024 # 8 MiB Review Comment: This doesn't really need to be a private variable. None of the others are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
