yangshangqing95 commented on code in PR #18108:
URL: https://github.com/apache/iceberg/pull/18108#discussion_r4020129740
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -210,14 +216,55 @@ public long fileSizeInBytes() {
return fileSizeInBytes;
}
+ void setSpecsById(Map<Integer, PartitionSpec> newSpecsById) {
+ this.specsById = newSpecsById;
+ }
+
@Override
public Integer specId() {
return specId;
}
@Override
public StructLike partition() {
Review Comment:
Nit, non-blocking: could we make the `TrackedFile.partition()` contract
explicit that the returned struct is shaped/ordered according to the file's
resolved partition spec? This PR makes that invariant important for adapters
and downstream evaluators, while the current method Javadoc only says it
returns the partition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
