kevinjqliu commented on issue #3233: URL: https://github.com/apache/iceberg-rust/issues/3233#issuecomment-5688194564
Re: whether we should keep the `DEPENDENCIES.rust.tsv` files and what value they provide. The TSVs are meant to be regenerated during the release process so reviewers can inspect the dependency licenses. I personally don’t find the checked-in snapshots useful, especially when they’re stale. The actual license check is already handled by `cargo deny`, which doesn’t read these files. I’m in favor of dropping them and running the same `cargo deny` check in PR CI (#3234), while keeping the release-time check. That way we catch dependencies that don’t meet our license policy at PR time, without requiring contributors to maintain generated files. Looks like the TSV process is inherited from OpenDAL, @Xuanwo do you have any suggestions on whether we can remove the TSV files? Am I missing anything regarding its use case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
