anoopj opened a new pull request, #3235:
URL: https://github.com/apache/iceberg-rust/pull/3235

   ## What changes are included in this PR?
   
   ObjectCache::get_manifest_list built the cache key from 
snapshot.schema_id().unwrap(), but schema-id is optional on snapshots in every 
table version (v1-v3 per spec, and already read as Option<SchemaId>), so a 
snapshot that omits it panicked on every scan (the object cache is on by 
default).
   
   schema-id does not belong in this key: ManifestListReader::load parses the 
manifest list from its bytes and the table format version only and never reads 
schema-id, and the manifest-list location is already unique per snapshot.
   
   ## Are these changes tested?
   
   Added new test `test_get_manifest_list_with_no_schema_id`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to