rdblue commented on code in PR #16936:
URL: https://github.com/apache/iceberg/pull/16936#discussion_r4020716500
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -267,27 +267,31 @@ public TrackedFile copyWithStats(Set<Integer>
requestedColumnIds) {
@Override
protected <T> T internalGet(int pos, Class<T> javaClass) {
- return javaClass.cast(getByPos(pos));
+ return javaClass.cast(getByPos(this, pos));
}
- private Object getByPos(int pos) {
+ /**
+ * Returns the value at the given position in TrackedFile schema field
order, shared with the
+ * write-direction wrappers so that the position-to-field mapping is defined
in one place.
Review Comment:
Utility methods should not state the places where they are used in Javadoc.
Javadoc should state the behavior and contract of the method. In addition,
Javadoc should document the arguments and return values using `@param` and
`@return`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
