huaxingao commented on code in PR #18015:
URL: https://github.com/apache/iceberg/pull/18015#discussion_r4020682538
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -478,6 +495,7 @@ public Table loadTable(SessionContext context,
TableIdentifier identifier) {
context,
identifier,
snapshotMode,
+ loadContext,
Review Comment:
In the below `cachedTable`, the cache key here is `(sessionId, identifier)`
and doesn't include the view chain, so a load through `view_B` finds the entry
saved by an earlier load through `view_A`. On a `200` that's invisible, since
the client rebuilds with the current context, but on a `304` it returns the
cached entry and its `FileIO` still carries `view_A`. Would the credentials
then be scoped to the wrong view?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
