szehon-ho commented on PR #18057: URL: https://github.com/apache/iceberg/pull/18057#issuecomment-5690431603
Looks good to me. The CRS examples now preserve the serialized case and align with the table spec, and the struct field escaping removes the definition-ID ambiguity. The corresponding UDF descriptions in `open-api/rest-catalog-open-api.yaml` still say that type strings and definition IDs contain no spaces. I think that can be aligned in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
